Arm backend: Exclude build metadata from license checks#19754
Merged
Conversation
perheld
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19754
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 8d07e3a with merge base ba6074c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Treat BUCK and TARGETS files as build metadata in the Arm pre-push license check so they do not need copyright headers. Signed-off-by: Per Held <per.held@arm.com> Change-Id: I4b3bbd1e03ba4b9c38fd06225156344985f0cc70
perheld
force-pushed
the
ph-ignore-buck-files
branch
from
9848334 to
8d07e3a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Arm backend pre-push hook’s license-header check to treat Buck build metadata as exempt from Arm copyright header requirements.
Changes:
- Extends the license-check skip list to include
BUCKandTARGETSfiles (intended as build metadata).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
178
to
181
| # Skip files with certain extensions | ||
| case "$committed_file" in | ||
| *.md|*.md.in|*.json|*.yml|*.yaml|*.cmake|*.patch|.gitignore|*.bzl) | ||
| *.md|*.md.in|*.json|*.yml|*.yaml|*.cmake|*.patch|.gitignore|*.bzl|BUCK|*/BUCK|TARGETS|*/TARGETS) | ||
| echo -e "${INFO} Skipping license check for ${committed_file} (excluded extension)" |
zingo
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat BUCK and TARGETS files as build metadata in the Arm pre-push license check so they do not need copyright headers.
Change-Id: I4b3bbd1e03ba4b9c38fd06225156344985f0cc70
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani